Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/proposal #92

Merged
merged 9 commits into from
Nov 19, 2024
Merged

Fix/proposal #92

merged 9 commits into from
Nov 19, 2024

Conversation

capetillo
Copy link
Collaborator

FIX/FEATURE: Proposal id selection

Background:
The proposal id was hardcoded when users requested a scheduled observation and an rti. Now, the user's proposals are presented as a drop down and they get to select it. If there are no proposals associated with the user, then they are presented with a link to submit a proposal at LCO. The last part may be temporary.

VISUALS

This is what it looks like on every component
Screenshot 2024-11-18 at 5 09 52 PM

@zemogle
Copy link
Contributor

zemogle commented Nov 19, 2024

Screenshot 2024-11-19 at 09 39 00
Most education users won't have as many proposals me but all science users will because we give them a new one each semester (not really sure why). I would:

  • Show the names not the proposal codes
  • Only show active proposals. They can't make requests to an old proposal.

@capetillo
Copy link
Collaborator Author

@zemogle there isn't a key of name, there's only id, title, and current. Do you mean title? Is that not too long? Let me know what you think : )
Screenshot 2024-11-19 at 9 25 23 AM

Copy link

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment on watcher vs event handler

src/components/Global/ProposalDropdown.vue Outdated Show resolved Hide resolved
src/components/Views/SchedulingView.vue Outdated Show resolved Hide resolved
@capetillo capetillo merged commit 987b1a9 into main Nov 19, 2024
1 check passed
@capetillo capetillo deleted the fix/proposal-id branch November 19, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants