OOP removal #129
Merged
OOP removal #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed source files: - abstractions.py - filters.py - objects.py - juju.py
- Includes fix to typehint in cloud.py
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes all of the object-oriented code in Jockey, which was the result of early optimization. This change makes the Jockey code and logic simpler, cleaner, and easier to maintain. This change introduces some regressions, such as not being able to filter objects by their Juju status, but these features will be re-implemented with a functional approach should they prove to be needed.
Type of Change
Testing
Many old tests have been removed. No new tests have been added.
Additional Information
Any additional information that reviewers should be aware of.
Checklist