feat: add avro logicaltypes #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
The logical types were working, when deserializing, however
durationanddecimalspecific properties were put in 'metadata'.This PR adds specific logicaltypes.
This pull request introduces support for Avro logical types in the
AsyncApiAvroSchemaDeserializerand adds corresponding classes for each logical type. The most important changes include adding new classes for logical types, updating the deserializer to handle these types, and adding new tests to ensure correct serialization and deserialization.Support for Avro Logical Types:
src/LEGO.AsyncAPI/Models/Avro/LogicalTypes/AvroDate.cs: AddedAvroDateclass to represent the Avro logical typedate.src/LEGO.AsyncAPI/Models/Avro/LogicalTypes/AvroDecimal.cs: AddedAvroDecimalclass to represent the Avro logical typedecimal, including properties forScaleandPrecision.src/LEGO.AsyncAPI/Models/Avro/LogicalTypes/AvroDuration.cs: AddedAvroDurationclass to represent the Avro logical typeduration.src/LEGO.AsyncAPI/Models/Avro/LogicalTypes/AvroUUID.cs: AddedAvroUUIDclass to represent the Avro logical typeuuid.src/LEGO.AsyncAPI/Models/Avro/LogicalTypes/LogicalType.cs: AddedLogicalTypeenum to define the different logical types.Deserializer Updates:
src/LEGO.AsyncAPI.Readers/V2/AsyncApiAvroSchemaDeserializer.cs: UpdatedAsyncApiAvroSchemaDeserializerto include fixed and pattern field maps for each logical type and addedLoadLogicalTypemethod to handle logical type deserialization. [1] [2] [3] [4]Tests:
test/LEGO.AsyncAPI.Tests/Models/AvroSchema_Should.cs: AddedSerializeV2_WithLogicalTypes_SerializesCorrectlytest to verify the serialization of Avro schemas with logical types.