First commit with attestation API from PDO's pull request #501 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Vavala <[email protected]>
cmickeyb
reviewed
Jan 29, 2025
| **Attestation generation.** | ||
| The library exposes the `init_attestation(params)` and `attestation_blob = get_attestation(statement)` APIs. | ||
| `params` is a json blob to initialize the internal state of the library for an attestation. The `statement` is a binary string which (in SGX) is hashed to generate the "report data" to be attested. | ||
| ```jsonc |
There was a problem hiding this comment.
Question: instead of runtime selection of the attestation method, can this just be compile time (or link time)? Make each method a separate library that can be linked. It seems unlikely that the attestation method would change for a particular application at run time.
cmickeyb
reviewed
Jan 29, 2025
| "hex_spid": "<hex encoded spid>", // only for EPID | ||
| "sig_rl": "<sigrl>" // only for EPID | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Given that EPID has been EOL'd, is there a reason to continue to support it?
cmickeyb
reviewed
Jan 29, 2025
|
|
||
| **Attestation verification.** | ||
| The attestation library exposes the `verify_evidence(evidence_blob, statement, code_id)` API. In SGX, the code identity refers to the `mrenclave` value. The verification result is simply `true` or `false`, depending on the outcome. The API mainly verifies: the chain of trust of the evidence (i.e., none for the `simulated` type; up to the IAS root CA for EPID; up to the SGX Root CA for the `dcap-direct-sgx` type; up to the ITA root CA for the `dcap-sgx` type. The respective root CA certificates are all retrieved at build time and compiled into the library. | ||
|
|
There was a problem hiding this comment.
one more request... can we differentiate between "integrity" of the evidence (meaning all the signature are valid) and "policy" for whether the evidence meets some set of requirements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation of the attestation API (extended from Hyperledger Fabric Private Chaincode), which was initially pushed in the PDO repo and integrated with the PDO build -- see hyperledger-labs/private-data-objects#501.