Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the sequence of inter-level data transfers in MethodOfLinesIntegrator #160

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Correct the sequence of inter-level data transfers in MethodOfLinesIntegrator #160

merged 1 commit into from
Nov 18, 2020

Conversation

nselliott
Copy link
Collaborator

This addresses issue #153 .

The sequence of inter-level operations in the Runge-Kutta loop was incorrect. The changes here reorganize the iteration of an RK step in this loop as follows:

  • Fill ghosts on all levels, including refinement operations where needed.
  • Patch-based RK-step advance on all levels
  • Coarsen data from finest to coarsest levels.

@nselliott
Copy link
Collaborator Author

LGTM

@nselliott nselliott merged commit a64e39f into master Nov 18, 2020
@nselliott nselliott deleted the feature/nselliott/mol-fix branch November 18, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wliuphd wliuphd wliuphd approved these changes

@davidbeckingsale davidbeckingsale Awaiting requested review from davidbeckingsale

@jonesholger jonesholger Awaiting requested review from jonesholger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nselliott @wliuphd