Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updatejsdb #298

Merged
merged 77 commits into from
Dec 18, 2024
Merged

Updatejsdb #298

merged 77 commits into from
Dec 18, 2024

Conversation

willis89pr
Copy link
Collaborator

Summary

If merged this pull request will update the database for js_file plugin.

Proposed changes

Moved the update js_file database script to the plugin's update db hook implementation.

willis89pr and others added 30 commits November 4, 2024 20:15
@willis89pr
Added plugin list subcommand functionality
6e7e488
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
45a1b6d 
for more information, see https://pre-commit.ci
@willis89pr
changed subcommand from list to display to avoid python builtin redef…
d141ce5 
…inition
@willis89pr
changed subcommand from list to display to avoid python builtin redef…
75afc0c 
…inition
@willis89pr
changed subcommand from list to display to avoid python builtin redef…
555490d 
…inition
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
dbd9fba 
for more information, see https://pre-commit.ci
@willis89pr
fixed import function
79a3675
@willis89pr
fixed import function
229d8b1
@willis89pr
Merge branch 'main' into CYT-828-add-plugin-command
4126841
@willis89pr
changed subcommand name to list in click decorator
be48bb5
@willis89pr
Merge remote-tracking branch 'origin/CYT-828-add-plugin-command' into…
efb07c6 
… CYT-828-add-plugin-command
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3f911a5 
for more information, see https://pre-commit.ci
@willis89pr
Changed subcommand definition name. Added docstring description to su…
261cc6e 
…bcommand
@willis89pr
Merge remote-tracking branch 'origin/CYT-828-add-plugin-command' into…
fabf213 
… CYT-828-add-plugin-command
@willis89pr
Changed subcommand definition name. Added docstring description to su…
5e20458 
…bcommand
@willis89pr
Added boiler plate for disable commmand.
b88b0e7
@willis89pr
Added disable plugin functionality.
52e0703
@willis89pr
Added disable subcommand to main.
768574d
@willis89pr
Added variables for config section and key and changed section to core.
3a8342c
@willis89pr
Re-implemented disable command with functionality in surfactant/plugi…
da8554f 
…n/manager.py
@willis89pr
Added print disabled plugins to list subcommand
be12bfa
@willis89pr
Added print disabled plugins to list subcommand.
4d27807
@willis89pr
Added plugin enable functionality.
62657de
@willis89pr
Merge branch 'main' into CYT-1123-plugin-enable-disable
40babc5
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7ac000a 
for more information, see https://pre-commit.ci
@willis89pr @nightlark
Update surfactant/cmd/plugin.py
c0b4a0b 
Simpler string formatting.

Co-authored-by: Ryan Mast <[email protected]>
@willis89pr @nightlark
Update surfactant/cmd/plugin.py
093b047 
Fixed typo.

Co-authored-by: Ryan Mast <[email protected]>
@willis89pr
Save.
dd4b055
@willis89pr
Added set_plugins function. Changed formatting of print_plugins
0ec3b91
@willis89pr
Added print_plugins in list command and changed formatting
03355a2
@willis89pr willis89pr requested a review from nightlark December 17, 2024 21:08
nightlark
nightlark reviewed Dec 18, 2024
View reviewed changes
surfactant/infoextractors/js_file.py Outdated Show resolved Hide resolved
surfactant/infoextractors/js_file.py Outdated Show resolved Hide resolved
surfactant/infoextractors/js_file.py Outdated Show resolved Hide resolved
surfactant/infoextractors/js_file.py Outdated Show resolved Hide resolved
surfactant/infoextractors/js_file.py Outdated Show resolved Hide resolved
willis89pr
willis89pr commented Dec 18, 2024
View reviewed changes
Copy link
Collaborator Author

@willis89pr willis89pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loads database on import. Downloads database only when surfactant plugin update-db <js_file or --all> is called.

willis89pr
willis89pr commented Dec 18, 2024
View reviewed changes
Copy link
Collaborator Author

@willis89pr willis89pr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloads database only when surfactant plugin update-db <js_file or --all> is called. Loads database on import. Warn only once if the database does not exist.

@nightlark nightlark enabled auto-merge (squash) December 18, 2024 20:17
@nightlark nightlark merged commit e471c5f into main Dec 18, 2024
14 checks passed
@nightlark nightlark deleted the updatejsdb branch December 18, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightlark nightlark nightlark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willis89pr @nightlark