Refactor and Relocate Native Library Pattern Loading #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… CYT-828-add-plugin-command
for more information, see https://pre-commit.ci
… CYT-828-add-plugin-command
for more information, see https://pre-commit.ci
Simpler string formatting. Co-authored-by: Ryan Mast <[email protected]>
Fixed typo. Co-authored-by: Ryan Mast <[email protected]>
- Introduced class to encapsulate database loading logic. - Added to initialize the database unless the command is update-db. - Moved database loading logic from module-level to class method for better encapsulation. - Improved logging during initialization.
…_lib_file.py module
for more information, see https://pre-commit.ci
nightlark
reviewed
Jan 14, 2025
nightlark
reviewed
Jan 14, 2025
nightlark
reviewed
Jan 14, 2025
nightlark
reviewed
Jan 14, 2025
for more information, see https://pre-commit.ci
…nto init-nativelib
nightlark
reviewed
Jan 14, 2025
for more information, see https://pre-commit.ci
Fixed typo. Co-authored-by: Ryan Mast <[email protected]>
nightlark
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the native library pattern loading logic by introducing a new class and relocates the script to a more appropriate module.
Proposed changes
Refactoring:
Introduced the NativeLibDatabaseManager class to encapsulate the database loading logic, enhancing code organization and maintainability.
Moved the database loading logic from a module-level function to a class method for better encapsulation.
Relocation:
Moved the native_libraries.get_emba_db.py script to the infoextractors.native_lib_file.py module, consolidating related functionality.
Initialization Hook:
Added an init_hook to initialize the database unless the command is "update-db", providing better control over the initialization process.
Improved logging to offer clear feedback during the initialization phase.