Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP intrinsics, candidate examples init change #1295

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Mar 19, 2024

This PR:

  • Adds HIP intrinsics to BitUtilities.hpp
  • Modifies quest_candidate_examples to initialize hexahedra and bounding boxes on device (follow up from previous PR improvement suggestion)

Related to #1282

@bmhan12 bmhan12 added Core Issues related to Axom's 'core' component Quest Issues related to Axom's 'quest' component Hip Issues related to Hip labels Mar 19, 2024
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmhan12 !

src/axom/quest/examples/quest_candidates_example.cpp Outdated Show resolved Hide resolved
@bmhan12 bmhan12 force-pushed the feature/han12/BVH_silo_hip_changes branch from 98f1141 to fe29dc3 Compare March 25, 2024 15:51
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bmhan12

@agcapps
Copy link
Member

agcapps commented Mar 25, 2024

Should this go into the release notes?

@bmhan12 bmhan12 force-pushed the feature/han12/BVH_silo_hip_changes branch from fe29dc3 to 40e50bb Compare March 26, 2024 16:05
@bmhan12 bmhan12 merged commit 5743116 into develop Mar 26, 2024
12 checks passed
@bmhan12 bmhan12 deleted the feature/han12/BVH_silo_hip_changes branch March 26, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issues related to Axom's 'core' component Hip Issues related to Hip Quest Issues related to Axom's 'quest' component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants