Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidre dest memory space when importing from Conduit #1460

Merged
merged 9 commits into from
Nov 5, 2024

Conversation

gunney1
Copy link
Contributor

@gunney1 gunney1 commented Oct 28, 2024

Summary

  • This PR is a feature
  • It does the following:
    • Changes where destination data is allocated when importing array from Conduit. Currently, data is allocated on host. New, data is allocated using the allocator of the parent Group.
    • Adds unit test for importing into a specific allocator id.
    • Fixes issue Deep copying View should use allocator id of parent #1458
    • Updates RELEASE-NOTES.

Without this change, it is still possible to re-allocate data after the import, but that would require walking a Group hierarchy to look for View's with data and re-allocating them individually. The new behavior is consistent with the behavior when deep-copying from a Sidre source.

Motivation

This change was needed in the work to support Blueprint meshes in shaping, #1452. I wanted to separate it to keep that PR as clean as possible.

…y space.

This makes importing Conduit array behave similar to deep copying from sidre.
@gunney1 gunney1 added the Sidre Issues related to Axom's 'sidre' component label Oct 28, 2024
@gunney1 gunney1 self-assigned this Oct 28, 2024
@gunney1 gunney1 changed the title Feature/gunney/conduit import memory space Sidre dest memory space when importing form Conduit Oct 28, 2024
@gunney1 gunney1 changed the title Sidre dest memory space when importing form Conduit Sidre dest memory space when importing from Conduit Oct 28, 2024
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gunney1

RELEASE-NOTES.md Outdated Show resolved Hide resolved
Co-authored-by: Kenny Weiss <[email protected]>
@kennyweiss kennyweiss self-requested a review October 28, 2024 21:12
Copy link
Member

@BradWhitlock BradWhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it will allocate using the parent allocator, as intended.

Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the API and the new tests!

@gunney1 gunney1 merged commit 8e5a3da into develop Nov 5, 2024
13 checks passed
@gunney1 gunney1 deleted the feature/gunney/conduit-import-memory-space branch November 5, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sidre Issues related to Axom's 'sidre' component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants