-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidre dest memory space when importing from Conduit #1460
Conversation
…y space. This makes importing Conduit array behave similar to deep copying from sidre.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gunney1
Co-authored-by: Kenny Weiss <[email protected]>
This assures that all immediate views of a group use the same allocator.
…om:LLNL/axom into feature/gunney/conduit-import-memory-space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it will allocate using the parent allocator, as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the API and the new tests!
…-import-memory-space
Summary
Group
.View
should use allocator id of parent #1458Without this change, it is still possible to re-allocate data after the import, but that would require walking a
Group
hierarchy to look forView
's with data and re-allocating them individually. The new behavior is consistent with the behavior when deep-copying from a Sidre source.Motivation
This change was needed in the work to support Blueprint meshes in shaping, #1452. I wanted to separate it to keep that PR as clean as possible.