Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run isort and codespell Against Repo & Add to CI #104

Merged
merged 6 commits into from
Jan 8, 2024

Conversation

alecbcs
Copy link
Member

@alecbcs alecbcs commented Jan 6, 2024

  • Add isort to list of style checks to keep files in line with Spack formatting requirements. (This'll save us later on when we want to upstream stuff to Spack/Ramble.)
  • Add codespell to style checks to alert us to (likely my) typos.

@alecbcs alecbcs added the ci CI, unit tests, GitHub actions label Jan 6, 2024
import shlex
import shutil
import subprocess
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What uses subprocess?

@pearce8 pearce8 merged commit d389f4f into LLNL:develop Jan 8, 2024
1 check passed
@alecbcs alecbcs deleted the add/isort-codespell-ci branch January 8, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI, unit tests, GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants