Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lammps #107

Merged
merged 27 commits into from
Jun 20, 2024
Merged

Adding lammps #107

merged 27 commits into from
Jun 20, 2024

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Jan 9, 2024

  • experiment specification
  • additional tags

@github-actions github-actions bot added the experiment New or modified experiment label Jan 9, 2024
@github-actions github-actions bot added the application New or modified application label Jan 9, 2024
@github-actions github-actions bot added the configs New or modified system config label Feb 8, 2024
env_vars:
set:
LD_LIBRARY_PATH: '/opt/cray/pe/cce/16.0.0/cce/x86_64/lib:$LD_LIBRARY_PATH'
MPICH_GPU_SUPPORT_ENABLED: 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pearce8 @scheibelp The code works on tioga, but I could not get around having to hard code LD_LIBRARY_PATH and MPICH_GPU_SUPPORT_ENABLED directly in ramble.yaml. Is it ok if we merge the PR right now and tackle this issue in a separate PR?

@rfhaque
Copy link
Collaborator

rfhaque commented Jun 20, 2024

@pearce8 @scheibelp This PR works on tioga. I was able to pass the runtime environment variables using package.py. We do not need any platform-specific variables in ramble.yaml

@rfhaque rfhaque marked this pull request as ready for review June 20, 2024 06:33
@rfhaque rfhaque requested a review from scheibelp June 20, 2024 06:33
@github-actions github-actions bot added the ci Involving Project CI & Unit Tests label Jun 20, 2024
@pearce8 pearce8 merged commit 4d08af3 into develop Jun 20, 2024
8 checks passed
@pearce8 pearce8 deleted the feature-lammps branch June 20, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application New or modified application ci Involving Project CI & Unit Tests configs New or modified system config experiment New or modified experiment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants