Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Fugaku system config #118

Merged
merged 21 commits into from
Feb 22, 2024
Merged

Adding a Fugaku system config #118

merged 21 commits into from
Feb 22, 2024

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Jan 19, 2024 •
edited by slabasan
Loading

@pearce8 Updated table, Fugaku config looks good. We might want to increase the content width of the page to reduce left/right scroll

Screenshot 2024-01-29 at 3 36 31 PM

@github-actions github-actions bot added the configs New or modified system config label Jan 19, 2024
@pearce8 pearce8 requested review from becker33 and alecbcs January 19, 2024 19:55
@pearce8 pearce8 added this to the v0.1.1 milestone Jan 20, 2024
@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 29, 2024
@github-actions github-actions bot added the experiment New or modified experiment label Jan 30, 2024
pearce8
pearce8 commented Feb 21, 2024
View reviewed changes
Copy link
Collaborator Author

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, updates only system files and the docs table.

The change to the openmp number of threads might as well happen because 13 is a strange number.

@pearce8 pearce8 removed the request for review from becker33 February 21, 2024 11:53
@pearce8 pearce8 requested a review from scheibelp February 21, 2024 11:53
@pearce8 pearce8 marked this pull request as ready for review February 21, 2024 11:54
scheibelp
scheibelp approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@scheibelp scheibelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this defines more compilers and packages than required, but I think that can be adjusted in a later PR.

@pearce8 pearce8 merged commit d97f257 into develop Feb 22, 2024
7 checks passed
@pearce8 pearce8 deleted the configs/fugaku branch February 22, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheibelp scheibelp scheibelp approved these changes

@alecbcs alecbcs Awaiting requested review from alecbcs

Assignees

@pearce8 pearce8

Labels
configs New or modified system config docs Improvements or additions to documentation experiment New or modified experiment
Projects
None yet
Milestone
v0.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@pearce8 @scheibelp @slabasan @jdomke