Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configs/lumi #141

Merged
merged 15 commits into from
Feb 27, 2024
Merged

Configs/lumi #141

merged 15 commits into from
Feb 27, 2024

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Feb 20, 2024

To resolve (possibly in the next PR):

  • partition (this is Lumi-C)
  • allocation (I removed project allocation from this config, but how should users include it if they do not want to make it public?)

pszi1ard and others added 2 commits February 21, 2024 07:27
cce builds work, gcc builds with GROMACS give spack concretizer errors.
@github-actions github-actions bot added the system New or modified system config label Feb 20, 2024
@pearce8 pearce8 requested a review from scheibelp February 20, 2024 20:36
Copy link
Collaborator

@scheibelp scheibelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few requests: I think the most important one is that this needs to specify an external cray-libsci installation in packages.yaml.

@github-actions github-actions bot added the docs Improvements or additions to documentation label Feb 22, 2024
@pszi1ard
Copy link
Collaborator

Note that it is called "LUMI", so I suggest renaming the directory.

I suggest adding to the machine config files' header that this is based on the configs from/pfs/lustrep1/appl/lumi/spack/etc/23.09/0.21.0-user and is tested with spack 0.21 (since benchpark checks out develop I guess it may break in the future).

@scheibelp
Copy link
Collaborator

Note that it is called "LUMI", so I suggest renaming the directory.

I think you are referring to configs/CSC-Lumi-HPECray-zen3-MI250X-Slingshot/, our general format for these names is: {organization-acronym}-{name-of-machine}-{generic-type-of-machine}-{target}-{fabric}. Are you disagreeing with the CSC part?

@pszi1ard
Copy link
Collaborator

pszi1ard commented Feb 27, 2024

I think you are referring to configs/CSC-Lumi-HPECray-zen3-MI250X-Slingshot/, our general format for these names is: {organization-acronym}-{name-of-machine}-{generic-type-of-machine}-{target}-{fabric}. Are you disagreeing with the CSC part?

No, I was referring to the fact that the official name is all caps "LUMI" not "Lumi", see https://www.csc.fi/en/lumi

@scheibelp scheibelp merged commit 4777ca0 into develop Feb 27, 2024
7 checks passed
@pszi1ard
Copy link
Collaborator

@pearce8 @scheibelp I just noticed that a few files are missing from this PR: config.yaml, modules.yaml, and upstream.yaml. Are these intentionally left out?

@pearce8 pearce8 deleted the configs/lumi branch February 28, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation system New or modified system config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants