-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amg comm cali v2 #318
base: develop
Are you sure you want to change the base?
Amg comm cali v2 #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gracenansamba Please test this on Dane using the Dane config I just added. We should stop using the Magma config on other systems. Please also test the develop on Dane.
@@ -34,7 +34,8 @@ ramble: | |||
software: | |||
packages: | |||
osu-micro-benchmarks: | |||
pkg_spec: osu-micro-benchmarks | |||
pkg_spec: osu-micro-benchmarks@comm_cali +mpi+openmp{modifier_spack_variant} | |||
# pkg_spec: osu-micro-benchmarks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gracenansamba @pearce8 osu-micro-benchmarks does not support the mpi and openmp variants (mpi is always enabled). We also need to add the comm_cali branch to the osu-micro-benchmarks package.py. It may be better to separate the amg2023 and OSU changes into two PRs. amg2023 comm_cali changes work on ruby and can be taken to main as its own PR.
@@ -31,7 +31,7 @@ class Amg2023(CMakePackage, CudaPackage, ROCmPackage): | |||
depends_on("caliper", when="+caliper") | |||
depends_on("adiak", when="+caliper") | |||
depends_on("hypre+caliper", when="+caliper") | |||
depends_on("[email protected]:") | |||
depends_on("hypre@3.1_comm_cali") #depends_on("hypre@2.31.0:") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends_on("hypre@3.1_comm_cali") #depends_on("hypre@2.31.0:") | |
depends_on("[email protected]:", when="~caliper") | |
depends_on("[email protected]_comm_cali", when="+caliper") |
2a2ff50
to
480cedf
Compare
480cedf
to
1fde852
Compare
Description
On this branch, I have added the new version on hypre and build on both
LLNL-Magma-Penguin-icelake-OmniPath and LLNL-Ruby-icelake-OmniPath but it gives the error below
Dependencies: FIXME:Add a list of any dependencies.
Fixes issue(s): FIXME:Add list of relevant issues.
Type of Change
Checklist:
If adding/modifying a system:
system.py
file.github/workflows
If adding/modifying a benchpark:
application.py
and (maybe)package.py
under a new directoryfor this benchmark
section
If adding/modifying a experiment:
experiment.py
under existing directory for specific benchmarkIf adding/modifying core functionality:
.github/workflows
and.gitlab/ci
unit tests (if needed)