-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] Testing Salmon/Openmp #391
Draft
dyokelson
wants to merge
13
commits into
LLNL:develop
Choose a base branch
from
dyokelson:salmon-test
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+799
−708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
experiment
New or modified experiment
ci
CI, unit tests, GitHub actions
labels
Oct 7, 2024
slabasan
force-pushed
the
salmon-test
branch
4 times, most recently
from
January 16, 2025 05:27
16f368a
to
406d7c3
Compare
pearce8
requested changes
Jan 17, 2025
slabasan
force-pushed
the
salmon-test
branch
2 times, most recently
from
January 21, 2025 19:28
a2d2bef
to
fb4a93c
Compare
use a consistent compiler between ruby and fugaku
update dry runs, salmon version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
application
ci
CI, unit tests, GitHub actions
experiment
New or modified experiment
system
New or modified system config
WIP
A work-in-progress not yet ready to commit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing dependence on the Fujitsu compiler.
This PR works on ruby with legacy salmon, but needs testing on Fugaku. I had to remove
-stdin
from theapplication.py
, and I'm concerned this is required by Fugaku but not other systems. Here are the steps to reproduce with this branch:Then follow the steps in output
Stephanie TODO:
experiment.py
and verify generatedramble.yaml
with hand written one in this PRdynamic cts ruby
Generated
ramble.yaml
: Missing section forrt
workload, is the compiler correct?Dependencies: FIXME:Add a list of any dependencies.
Fixes issue(s): Part of #460
Type of Change
Checklist:
If adding/modifying a system:
system.py
file.github/workflows
If adding/modifying a benchpark:
application.py
and (maybe)package.py
under a new directoryfor this benchmark
section
If adding/modifying a experiment:
experiment.py
under existing directory for specific benchmarkIf adding/modifying core functionality:
.github/workflows
and.gitlab/ci
unit tests (if needed)