Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site CI: report job status, check for exit codes, add machines and benchmarks #402

Merged
merged 24 commits into from
Dec 13, 2024

Conversation

slabasan
Copy link
Collaborator

@slabasan slabasan commented Oct 18, 2024

Merge after #396. This PR extends CI support for site testing benchmarks. Closes #367.

  • draft status to toggle running of gitlab
  • reporting pass/fail status to github
  • testing new workflow with saxpy on tioga
  • kripke (gpu) on tioga
  • add site user @alecbcs
  • look at exit modifier in ramble

Save notes:
error message if try to init an experiment iwht a unsupported variant?
add grep here for available system+experiment variants (look for return code)
if grep CUDA; then
append CUDA to list of variants
iterate over list of variants
append cuda variant job to larger benchmark job
for loop over variants

@slabasan slabasan added the ci CI, unit tests, GitHub actions label Oct 18, 2024
@slabasan slabasan changed the title ci: add local testing of modified benchmarks extended site CI support Oct 18, 2024
@slabasan slabasan added the WIP A work-in-progress not yet ready to commit label Oct 18, 2024
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch 3 times, most recently from 886510d to 7559acf Compare October 22, 2024 23:45
@slabasan slabasan removed the WIP A work-in-progress not yet ready to commit label Oct 23, 2024
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch 6 times, most recently from 08e9abb to f9c763d Compare October 30, 2024 20:49
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch 5 times, most recently from c4f25e1 to 7db9e03 Compare November 2, 2024 02:59
@slabasan slabasan changed the title extended site CI support site CI: report job status, check for exit codes Nov 2, 2024
@slabasan slabasan changed the title site CI: report job status, check for exit codes site CI: report job status, check for exit codes, add machines and benchmarks Nov 2, 2024
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch from 7db9e03 to 65e0a75 Compare November 2, 2024 16:02
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch 2 times, most recently from f0b9dea to 7991544 Compare November 13, 2024 21:29
@slabasan
Copy link
Collaborator Author

@pearce8 This one ready for merge

@slabasan slabasan requested a review from pearce8 November 13, 2024 21:30
@slabasan slabasan enabled auto-merge (squash) November 13, 2024 21:53
@slabasan slabasan disabled auto-merge November 13, 2024 21:53
@alecbcs alecbcs self-requested a review November 14, 2024 01:04
Copy link
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slabasan it looks like this pipeline is running too many jobs / reserving too many nodes on Tioga. We've been asked to pause or halt until we can limit the number of jobs.

@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch from 951d2b7 to a8abf39 Compare November 15, 2024 03:08
- move from shell to batch runners
- workflow is interruptible, so new commits will cancel existing pipeline
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch from 10ba2ce to 738a85e Compare December 10, 2024 16:41
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch 2 times, most recently from 9798066 to 8a7b5db Compare December 11, 2024 02:56
@alecbcs alecbcs force-pushed the add/site-ci-tests-more-features branch from 451dd50 to c4d8d5d Compare December 12, 2024 22:01
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch from 477c76a to d5ad88e Compare December 13, 2024 16:44
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch from d5ad88e to 1ac3e74 Compare December 13, 2024 17:54
@slabasan slabasan dismissed stale reviews from pearce8 and alecbcs December 13, 2024 18:19

requested changes addressed

@slabasan
Copy link
Collaborator Author

@pearce8 Ready for merge

@pearce8 pearce8 merged commit bb48996 into develop Dec 13, 2024
8 checks passed
@pearce8 pearce8 deleted the add/site-ci-tests-more-features branch December 13, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI, unit tests, GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI of experiments on clusters
3 participants