-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site CI: report job status, check for exit codes, add machines and benchmarks #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
886510d
to
7559acf
Compare
08e9abb
to
f9c763d
Compare
c4f25e1
to
7db9e03
Compare
7db9e03
to
65e0a75
Compare
f0b9dea
to
7991544
Compare
@pearce8 This one ready for merge |
alecbcs
previously requested changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slabasan it looks like this pipeline is running too many jobs / reserving too many nodes on Tioga. We've been asked to pause or halt until we can limit the number of jobs.
951d2b7
to
a8abf39
Compare
- move from shell to batch runners - workflow is interruptible, so new commits will cancel existing pipeline
10ba2ce
to
738a85e
Compare
- fix time parameter - variable for job run parameters
add rule to test_job
9798066
to
8a7b5db
Compare
451dd50
to
c4d8d5d
Compare
477c76a
to
d5ad88e
Compare
d5ad88e
to
1ac3e74
Compare
requested changes addressed
@pearce8 Ready for merge |
pearce8
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #396. This PR extends CI support for site testing benchmarks. Closes #367.
Save notes:
error message if try to init an experiment iwht a unsupported variant?
add grep here for available system+experiment variants (look for return code)
if grep CUDA; then
append CUDA to list of variants
iterate over list of variants
append cuda variant job to larger benchmark job
for loop over variants