-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ramble version #523
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is gitlab CI failing?
@slabasan can you help me look at the CI logs tomorrow? I'm having trouble navigating gitlab to find more error details. All I can see is we're getting an exit code 1 during spack install:
|
@dyokelson I'm seeing salmon-related commits in this PR, is this expected? |
@Brink2 Yea, the ramble update changed the inheritance and removed support for "SpackApplication" so those are the only changes. It shouldn't break in old salmon/genesis until we update ramble so should be okay no matter which order these PRs get merged. |
Description
Update pinned version of Ramble to one from December 17, 2025
Dependencies: Ramble removes support for "SpackModifier" and the replacement is "BasicModifier"
Fixes issue(s): This will be required to get the new Ramble for upcoming caliper metadata functionality.
Type of Change
Checklist:
If adding/modifying a system:
system.py
file.github/workflows
If adding/modifying a benchpark:
application.py
and (maybe)package.py
under a new directoryfor this benchmark
section
If adding/modifying a experiment:
experiment.py
under existing directory for specific benchmarkIf adding/modifying core functionality:
.github/workflows
and.gitlab/ci
unit tests (if needed)