-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Copyright, enforce license headers on all files #74
Conversation
@slabasan Can you please work through a PR to check the copyright in each file? |
cf6cef5
to
a2f030b
Compare
- add license.py for verifying headers - add license header to docs
1155156
to
7a6a1c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this seems good: removing licenses in various files leads to a failure in the verifier (as desired), and modifying the license identifier also causes a failure (as desired). Constraints on date also appear to work (although error message isn't clear in that case)
- (minor issue) if I change
configs/ats4/variables.yaml
like so:
-# Copyright 2023 Lawrence Livermore National Security, LLC and other
+# Copyright 2021 Lawrence Livermore National Security, LLC and other
then the error message is unclear IMO
/Users/scheibel1/Desktop/benchmarking/benchpark/configs/ats4/variables.yaml: SPDX license identifier missing
1 improperly licensed files
files with wrong SPDX-License-Identifier: 0
files not containing expected license: 1
- (I assume this is fine) if I change
configs/ats4/variables.yaml
like so
-# SPDX-License-Identifier: Apache-2.0
+# SPDX-License-Identifier: (Apache-2.0 OR MIT)
then I get a failure (which I assume is acceptable, even though mixing these licenses is fine, we don't want to give flexibility on that).
Co-authored-by: Alec Scott <[email protected]>
5e2b9c0
to
21065c8
Compare
21065c8
to
4690aec
Compare
Adding the top level copyright. Which of the files should have the copyright at the top?