Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Copyright, enforce license headers on all files #74

Merged
merged 10 commits into from
Dec 22, 2023

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Dec 15, 2023

Adding the top level copyright. Which of the files should have the copyright at the top?

  • package.py that our team develops in Benchpark? What happens to copyright when we push to Spack builtins?
  • application.py that our team develops in Benchpark? What happens to copyright when we push to Ramble builtins?
  • system configs?

@pearce8
Copy link
Collaborator Author

pearce8 commented Dec 18, 2023

@slabasan Can you please work through a PR to check the copyright in each file?

@pearce8 pearce8 assigned slabasan and unassigned scheibelp Dec 18, 2023
@pearce8 pearce8 added this to the v0.1.1 milestone Dec 19, 2023
@pearce8 pearce8 added the bug Something isn't working label Dec 19, 2023
@pearce8 pearce8 self-assigned this Dec 19, 2023
@slabasan slabasan marked this pull request as ready for review December 19, 2023 06:32
@pearce8 pearce8 assigned pearce8 and unassigned pearce8 Dec 19, 2023
@pearce8 pearce8 requested review from alecbcs and removed request for becker33 December 19, 2023 20:13
Copy link
Collaborator

@scheibelp scheibelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this seems good: removing licenses in various files leads to a failure in the verifier (as desired), and modifying the license identifier also causes a failure (as desired). Constraints on date also appear to work (although error message isn't clear in that case)

  1. (minor issue) if I change configs/ats4/variables.yaml like so:
-# Copyright 2023 Lawrence Livermore National Security, LLC and other
+# Copyright 2021 Lawrence Livermore National Security, LLC and other

then the error message is unclear IMO

/Users/scheibel1/Desktop/benchmarking/benchpark/configs/ats4/variables.yaml: SPDX license identifier missing
1 improperly licensed files
 files with wrong SPDX-License-Identifier:   0
 files not containing expected license:      1
  1. (I assume this is fine) if I change configs/ats4/variables.yaml like so
-# SPDX-License-Identifier: Apache-2.0
+# SPDX-License-Identifier: (Apache-2.0 OR MIT)

then I get a failure (which I assume is acceptable, even though mixing these licenses is fine, we don't want to give flexibility on that).

.github/workflows/scripts/license.py Outdated Show resolved Hide resolved
@pearce8 pearce8 merged commit 42fbe1e into develop Dec 22, 2023
6 checks passed
@pearce8 pearce8 deleted the feature/copyright branch December 22, 2023 22:08
@slabasan slabasan changed the title Adding Copyright Adding Copyright, enforce license headers on all files Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants