Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing magic #79

Merged
merged 17 commits into from
Dec 28, 2023
Merged

Removing magic #79

merged 17 commits into from
Dec 28, 2023

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Dec 18, 2023

Removing references to site-specific compiler wrappers.

@pearce8
Copy link
Collaborator Author

pearce8 commented Dec 18, 2023

@rfhaque Please test all relevant benchmarks on the updated systems.

@pearce8 pearce8 added the bug Something isn't working label Dec 19, 2023
@pearce8 pearce8 added this to the v0.1.1 milestone Dec 19, 2023
@pearce8 pearce8 requested review from rfhaque and removed request for becker33 December 20, 2023 01:01
@pearce8 pearce8 marked this pull request as ready for review December 20, 2023 01:04
Copy link
Collaborator

@becker33 becker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, commenting instead of approving because @rfhaque is doing manual testing.

configs/ats4/auxiliary_software_files/packages.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@rfhaque rfhaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pearce8 @scheibelp @becker33 Tested with the spack commit #8371bb4e. The following benchmarks have been tested

  1. amg2023 (openmp/cts1, openmp/x86, openmp/ats2, openmp/ats4, rocm/ats4, cuda/ats2)
  2. saxpy (openmp/ats4, rocm/ats4)
  3. raja-perf (openmp/ats4, mpi-only/ats4, rocm/ats4)

cc: /opt/cray/pe/cce/16.0.0/bin/craycc
cxx: /opt/cray/pe/cce/16.0.0/bin/crayCC
f77: /opt/cray/pe/cce/16.0.0/bin/crayftn
fc: /opt/cray/pe/cce/16.0.0/bin/crayftn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pearce8 amg2023 fails with the native cray compiler. It depends on workarounds in the magic wrapper

@pearce8
Copy link
Collaborator Author

pearce8 commented Dec 28, 2023

AMG fails on tioga:

configure: error: linking to Fortran libraries from C fails

Moving work on this to a separate PR#89.

@pearce8 pearce8 merged commit f2a8abf into develop Dec 28, 2023
5 checks passed
@pearce8 pearce8 deleted the patch-removing-magic branch December 28, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants