-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing magic #79
Removing magic #79
Conversation
@rfhaque Please test all relevant benchmarks on the updated systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, commenting instead of approving because @rfhaque is doing manual testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pearce8 @scheibelp @becker33 Tested with the spack commit #8371bb4e. The following benchmarks have been tested
- amg2023 (openmp/cts1, openmp/x86, openmp/ats2, openmp/ats4, rocm/ats4, cuda/ats2)
- saxpy (openmp/ats4, rocm/ats4)
- raja-perf (openmp/ats4, mpi-only/ats4, rocm/ats4)
cc: /opt/cray/pe/cce/16.0.0/bin/craycc | ||
cxx: /opt/cray/pe/cce/16.0.0/bin/crayCC | ||
f77: /opt/cray/pe/cce/16.0.0/bin/crayftn | ||
fc: /opt/cray/pe/cce/16.0.0/bin/crayftn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pearce8 amg2023 fails with the native cray compiler. It depends on workarounds in the magic wrapper
AMG fails on tioga:
Moving work on this to a separate PR#89. |
Removing references to site-specific compiler wrappers.