-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch/system names #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two big picture comments:
- I think the names for these systems should include the canonical name for the system on which they were tested. E.g.
tioga-HPECray-EPICzen3-...
- I think we should document the order of fields in this naming scheme.
Co-authored-by: Greg Becker <[email protected]>
I worry about this, because I explicitly want the Frontier and Lumi users to be able to find this. So, I only name tioga in the system-tested. I do wonder if we should allow multiple system-tested (i.e., once they use it on Frontier, and if they didn't need to change it, would add Frontier to the list. I am also wondering if we need a field to list the systems with this architecture that we know - explicitly saying that Frontier and Lumi have the same hardware, and make that searchable? While I think this file addresses the hardware questions, I do worry about the software stack. What do we do if Tioga defaults to a different compiler version than Frontier? or, multiple sites have CI set up, and one of the sites moves up the compiler version?
Yes! We badly need a schema. And I do want to make these readable in the docs. So, do you think I should add comments in each of these files, or do the comments go in the docs - and eventually into the schema? |
Co-authored-by: Greg Becker <[email protected]>
Co-authored-by: Greg Becker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've either resolved, or decided on resolving issues in a future PR.
Giving systems descriptive names, mirroring the Top500 naming.
Defining system_definition.yaml per system. In a future PR: