Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/system names #81

Merged
merged 26 commits into from
Dec 22, 2023
Merged

Patch/system names #81

merged 26 commits into from
Dec 22, 2023

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Dec 19, 2023

Giving systems descriptive names, mirroring the Top500 naming.

Defining system_definition.yaml per system. In a future PR:

  • Need a system_definition template
  • Make system definitions searchable
  • Script to make a table of systems defined for docs

@pearce8 pearce8 added the feature New feature or request label Dec 19, 2023
@pearce8 pearce8 added this to the v0.1.1 milestone Dec 19, 2023
@pearce8 pearce8 requested a review from becker33 December 19, 2023 09:30
@pearce8 pearce8 marked this pull request as ready for review December 20, 2023 06:21
@pearce8 pearce8 marked this pull request as draft December 20, 2023 06:23
@pearce8 pearce8 self-assigned this Dec 20, 2023
Copy link
Collaborator

@becker33 becker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two big picture comments:

  1. I think the names for these systems should include the canonical name for the system on which they were tested. E.g.

tioga-HPECray-EPICzen3-...

  1. I think we should document the order of fields in this naming scheme.

configs/AWS-Hpc7a-EPYC4-EFA/system_definition.yaml Outdated Show resolved Hide resolved
configs/AWS-Hpc7a-EPYC4-EFA/system_definition.yaml Outdated Show resolved Hide resolved
configs/IBM-POWER9-V100-Infiniband/system_definition.yaml Outdated Show resolved Hide resolved
configs/x86/system_definition.yaml Outdated Show resolved Hide resolved
configs/x86/system_definition.yaml Outdated Show resolved Hide resolved
@pearce8
Copy link
Collaborator Author

pearce8 commented Dec 22, 2023

Two big picture comments:

  1. I think the names for these systems should include the canonical name for the system on which they were tested. E.g.

tioga-HPECray-EPICzen3-...

I worry about this, because I explicitly want the Frontier and Lumi users to be able to find this. So, I only name tioga in the system-tested.

I do wonder if we should allow multiple system-tested (i.e., once they use it on Frontier, and if they didn't need to change it, would add Frontier to the list.

I am also wondering if we need a field to list the systems with this architecture that we know - explicitly saying that Frontier and Lumi have the same hardware, and make that searchable?

While I think this file addresses the hardware questions, I do worry about the software stack. What do we do if Tioga defaults to a different compiler version than Frontier? or, multiple sites have CI set up, and one of the sites moves up the compiler version?

  1. I think we should document the order of fields in this naming scheme.

Yes! We badly need a schema. And I do want to make these readable in the docs. So, do you think I should add comments in each of these files, or do the comments go in the docs - and eventually into the schema?

@pearce8 pearce8 requested a review from becker33 December 22, 2023 04:51
@pearce8 pearce8 marked this pull request as ready for review December 22, 2023 19:30
docs/add-a-system-config.rst Outdated Show resolved Hide resolved
docs/add-a-system-config.rst Outdated Show resolved Hide resolved
docs/add-a-system-config.rst Outdated Show resolved Hide resolved
pearce8 and others added 2 commits December 22, 2023 13:43
Co-authored-by: Greg Becker <[email protected]>
Co-authored-by: Greg Becker <[email protected]>
Copy link
Collaborator Author

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've either resolved, or decided on resolving issues in a future PR.

docs/add-a-system-config.rst Outdated Show resolved Hide resolved
docs/add-a-system-config.rst Outdated Show resolved Hide resolved
@pearce8 pearce8 merged commit 95b7af7 into develop Dec 22, 2023
6 checks passed
@pearce8 pearce8 deleted the patch/system-names branch December 22, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants