Fixes for tags that affected PointQuery on some systems. #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaroncblack
reviewed
Oct 10, 2024
src/libs/relay/conduit_relay_mpi.cpp
Outdated
| { | ||
| return (tag < MPI_TAG_UB) ? ((tag >= 0) ? tag : MPI_TAG_UB) : MPI_TAG_UB; | ||
| // Get the tag upper bound for the communicator. | ||
| // MPI_Comm_get_attr with MPI_TAG_UB is not a very reliable function. |
There was a problem hiding this comment.
That's always fun :( Thanks for identifying this issue.
cyrush
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rzadams, the MPI does not like large tag values. The PointQuery algorithm (and others) were using large tag values. The mechanism put in place to query a communicator's upper tag limit was not quite right before. This PR updates some of that logic and lowers some tag values so they're more likely to work with that MPI.
Also, in relay::mpi::communicate_using_schema it was possible for a user-registered error function to prevent exceptions from being thrown when needed. The class now temporarily suspends user-registered warning/error functions so exceptions will get thrown if MPI errors or other errors occur. This should make errors easier to diagnose.