specset::to_silo rewrite #1347
Merged
specset::to_silo rewrite #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrush
reviewed
Jan 10, 2025
| // material map and the final zone is mixed and contains that material, | ||
| // then we can get an index that is out of bounds. This is ok because | ||
| // downstream tools like VisIt read based on the number of species, so | ||
| // even though the index is garbage it goes unused. |
There was a problem hiding this comment.
Add to comment that Silo requires a slot for this data because the buffer indexing needs be consistent with the material indices? (Is that the right way to say it?)
There was a problem hiding this comment.
note included below
JustinPrivitera
deleted the
task/JustinPrivitera/01_09_25/to_silo_specsets_rewrite
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle the case where not all materials have species, use some silo optimizations, tests for many strange cases.