Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use C++17 #703

Merged
merged 2 commits into from
Feb 10, 2025
Merged

use C++17 #703

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9ef443
create branch
nychiang Jan 24, 2025
28a1e2c
fix
nychiang Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
cmake_minimum_required (VERSION 3.18)

set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++17 -lstdc++fs ")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is portable. It will probably not work with MSVC, for example.

Kitware suggests adding language standards to targets such as

target_compile_features(HIOP PRIVATE cxx_std_17)

My understanding is that the built-in target cxx_std_17 is supposed to add correct flags for the compiler of your selection.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pelesh We are worrying about if this PR will affect ExaGO, as it uses c++14. see here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt it is going to be an issue, because ExaGO only links to HiOp.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after checking others' code, e.g., RAJA, MFEM, etc..., I don't think I need to specify -std=c++17 or target_compile_features. Just pushed another commit for review.

set(CMAKE_POSITION_INDEPENDENT_CODE ON)
set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
set(CMAKE_CUDA_SEPARABLE_COMPILATION ON)
Expand Down Expand Up @@ -127,7 +129,7 @@ list(APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake)

target_compile_features(hiop_options
INTERFACE
cxx_std_14
cxx_std_17
cxx_alignas
cxx_alignof
cxx_attributes
Expand Down Expand Up @@ -237,8 +239,9 @@ if(HIOP_USE_GPU)
check_language(CUDA)

if(NOT DEFINED CMAKE_CUDA_STANDARD)
set(CMAKE_CUDA_STANDARD 14)
set(CMAKE_CUDA_STANDARD 17)
set(CMAKE_CUDA_STANDARD_REQUIRED ON)
set(CUDA_NVCC_FLAGS "-std=c++17")
endif()

if(NOT CMAKE_CUDA_ARCHITECTURES)
Expand Down
Loading