Cmake option HIOP_TEST_WITH_SLURM #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests on machines that use the slurm scheduler and wherein mpirun is not available
|
this was long overdue, thanks! have you tested it on any of the LC machines? |
|
Yes, I tested on ruby last night. All make tests passed having built with the option. |
|
Alternatively,you could just let user specify the command to run tests rather than offering a few options. @cameronrutherford did something like that for ExaGO. The idea back then was to implement similar in HiOp. |
cnpetra
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including an option
HIOP_TEST_WITH_SLURMin the Cmake file in order that the tests can be run usingsruninstead ofmpirunon machines running slurm schedulers.