Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRI-adaptivity #564

Merged
merged 321 commits into from
Dec 4, 2024
Merged

MRI-adaptivity #564

merged 321 commits into from
Dec 4, 2024

Conversation

drreynolds
Copy link
Collaborator

@drreynolds drreynolds commented Sep 5, 2024 •
edited
Loading

I think that this PR is now ready for full review.

Note: I removed all of the changesets that I'd pulled from @Steven-Roberts's PR #547 to simplify the review process for this PR.

@drreynolds drreynolds added this to the SUNDIALS Next milestone Sep 5, 2024
@drreynolds drreynolds mentioned this pull request Sep 10, 2024
Closed
balos1
balos1 previously requested changes Sep 24, 2024
View reviewed changes
doc/arkode/guide/source/Usage/MRIStep/Custom_Inner_Stepper/Description.rst Outdated Show resolved Hide resolved
doc/shared/sunadaptcontroller/SUNAdaptController_Description.rst Outdated Show resolved Hide resolved
doc/shared/sunadaptcontroller/SUNAdaptController_MRIHTol.rst Outdated Show resolved Hide resolved
examples/arkode/CXX_serial/CMakeLists.txt Outdated Show resolved Hide resolved
examples/arkode/CXX_serial/ark_kpr_nestedmri.cpp Show resolved Hide resolved
examples/arkode/C_serial/CMakeLists.txt Outdated Show resolved Hide resolved
examples/arkode/C_serial/CMakeLists.txt Outdated Show resolved Hide resolved
examples/arkode/C_serial/ark_kpr_mri.c Outdated Show resolved Hide resolved
examples/arkode/C_serial/ark_kpr_mri.c Outdated Show resolved Hide resolved
include/arkode/arkode.h Outdated Show resolved Hide resolved
Steven-Roberts
Steven-Roberts reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@Steven-Roberts Steven-Roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass at docs

CHANGELOG.md Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Show resolved Hide resolved
doc/shared/RecentChanges.rst Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/shared/sunadaptcontroller/SUNAdaptController_MRIHTol.rst Outdated Show resolved Hide resolved
doc/shared/sunadaptcontroller/SUNAdaptController_MRIHTol.rst Outdated Show resolved Hide resolved
doc/shared/sunadaptcontroller/SUNAdaptController_Description.rst Outdated Show resolved Hide resolved
gardner48
gardner48 requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor updates and some additions to the SUNStepper interface to align with the MRIInnerStepper updates

doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
src/arkode/arkode_mristep.c Outdated Show resolved Hide resolved
src/arkode/arkode_mristep.c Show resolved Hide resolved
src/arkode/arkode_mristep.c Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
doc/shared/RecentChanges.rst Show resolved Hide resolved
@drreynolds
Copy link
Collaborator Author

I believe that the only remaining item is for the missing items from the SUNStepper PR in mriStepInnerStepper_EvolveSUNStepper to be added here.

@drreynolds drreynolds requested a review from gardner48 December 4, 2024 04:58
@gardner48 gardner48 mentioned this pull request Dec 4, 2024
Merged
gardner48 pushed a commit to sundials-codes/answers that referenced this pull request Dec 4, 2024
@drreynolds
Feature: MRI Adaptivity (#40)
294c370 
Update answers for LLNL/sundials#564
gardner48
gardner48 reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dan's changes look good to me. All that remains are the SUNStepper items, I think those could either be addressed here or in a follow-on PR.

gardner48
gardner48 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SUNStepper changes look good. We should address the SUNStepper / H-Tol controller compatibility in a follow-on PR.

@gardner48 gardner48 merged commit a5850b9 into develop Dec 4, 2024
30 checks passed
@gardner48 gardner48 deleted the feature/mri-adaptivity branch December 4, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardner48 gardner48 gardner48 approved these changes

@balos1 balos1 balos1 left review comments

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

@Steven-Roberts Steven-Roberts Awaiting requested review from Steven-Roberts

Assignees
No one assigned
Labels
enhancement new-feature pkg-ARKODE
Projects
None yet
Milestone
SUNDIALS 7.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@drreynolds @balos1 @Steven-Roberts @gardner48