Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Optional Argument from _fill_perfdata #194

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

michaelmckinsey1
Copy link
Collaborator

Always fill numerical columns with np.nan to make functionality clearer.

@michaelmckinsey1 michaelmckinsey1 self-assigned this Jul 10, 2024
@michaelmckinsey1 michaelmckinsey1 added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors labels Jul 10, 2024
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One minor comment is that it's probably better to use NaN in the comments, but that's so minor that it's fine if you don't do that.

Also, whenever it's no longer experimental in pandas, we should probably switch to using pandas.NA. It's a pandas-specific type for representing missing data that works for all pandas data types. So, NA can be interpreted as Int64Dtype, StringDtype, Float64Dtype, BooleanDtype, and even the newer ArrowDtype.

@pearce8 this is ready for your review

@ilumsden ilumsden requested a review from pearce8 July 11, 2024 00:28
@ilumsden ilumsden added status-approved No more revisions are required on this PR and it is ready for merge and removed status-ready-for-review This PR is ready to be reviewed by assigned reviewers labels Jul 11, 2024
@michaelmckinsey1
Copy link
Collaborator Author

Looks good.

One minor comment is that it's probably better to use NaN in the comments, but that's so minor that it's fine if you don't do that.

Also, whenever it's no longer experimental in pandas, we should probably switch to using pandas.NA. It's a pandas-specific type for representing missing data that works for all pandas data types. So, NA can be interpreted as Int64Dtype, StringDtype, Float64Dtype, BooleanDtype, and even the newer ArrowDtype.

@pearce8 this is ready for your review

I reverted the change back to "NaN". They actually were "NaN" before and I had changed it to "nan" to match np.nan. However, since you mentioned it this doesn't make sense, as we should only be using NaN or np.nan, and NaN makes more sense in the context of comments.

@pearce8 pearce8 merged commit 72fca53 into LLNL:develop Jul 11, 2024
4 checks passed
Yejashi pushed a commit to TauferLab/thicket that referenced this pull request Sep 4, 2024
* Remove optional argument from _fill_perfdata to always fill with NaN

* Fix spelling
@slabasan slabasan added this to the 2024.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-approved No more revisions are required on this PR and it is ready for merge type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants