-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Optional Argument from _fill_perfdata #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
One minor comment is that it's probably better to use NaN
in the comments, but that's so minor that it's fine if you don't do that.
Also, whenever it's no longer experimental in pandas, we should probably switch to using pandas.NA
. It's a pandas-specific type for representing missing data that works for all pandas data types. So, NA
can be interpreted as Int64Dtype
, StringDtype
, Float64Dtype
, BooleanDtype
, and even the newer ArrowDtype
.
@pearce8 this is ready for your review
a9fa8a8
to
2f470a4
Compare
I reverted the change back to "NaN". They actually were "NaN" before and I had changed it to "nan" to match |
* Remove optional argument from _fill_perfdata to always fill with NaN * Fix spelling
Always fill numerical columns with
np.nan
to make functionality clearer.