Copy env file and directory to support includes #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapman39
reviewed
Nov 27, 2024
|
This doesn't appear to cause any issues in Serac, but I am worried there may be some consequence down the road. Does Spack not support moving external files to the Spack Environment that are included in the |
|
@adrienbernede personally im ok with merging but @white238 @cyrush thoughts? |
Co-authored-by: Alex Tyler Chapman <[email protected]>
chapman39
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #137
This allows
spack.yamlfiles to include configuration files as long as they belong to the same directory or sub-directories.Note:
spack env createis not run anymore for existing spack.yaml file. Copy works fine in my tests, but there might be a side effect.