Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CMAKE_CXX_STANDARD #339

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix CMAKE_CXX_STANDARD #339

merged 1 commit into from
Jun 25, 2024

Conversation

wkindling
Copy link
Contributor

I got a CMake error when using units as a third-party dependency using CPM. Changing ${CMAKE_CXX_STANDARD} to CMAKE_CXX_STANDARD fixed it.

@phlptp
Copy link
Collaborator

phlptp commented Jun 4, 2024

what version of CMAKE were you testing with?

@wkindling
Copy link
Contributor Author

My cmake version is 3.29.0-rc4. And the error was like:

[cmake] -- Third-party: creating target 'units'
[cmake] CMake Error at build/_deps/units-src/units/CMakeLists.txt:155 (if):
[cmake]   if given arguments:
[cmake] 
[cmake]     "GREATER" "16"
[cmake] 
[cmake]   Unknown arguments specified

@phlptp phlptp merged commit 0e7f8ea into LLNL:main Jun 25, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants