Find pyarrow module automatically for Arrow and Parquet #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Find pyarrow module executing python script if A) PIP_PYARROW_ROOT is not set and B) find_package can't find Parquet or Arrow
|
@rogerpearce @steiltre |
|
Close this PR as more features were added and need to create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional way to find Arrow and Parquet (described as step 3 below).
Here is how Arrow and Parquet are searched once this PR is merged:
If PIP_PYARROW_ROOT is set, try to find Arrow and Parquet installed along with pyarrow by PIP
If Arrow or Parquet is not found, try to find Arrow and Parquet using CMake's find_package()
If Arrow or Parquet is not found still:
Try to find a Python 3 interpreter on the system using CMake's FindPython3 module.
If Python 3 interpreter is found, try to find a pyarrow module by executing a Python 3 script.
If the pyarrow module is found, assign its location to PIP_PYARROW_ROOT (assuming the pyarrow module is installed by PIP) and execute step 1 again.