Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sbromberger/fix templates #263

Closed
wants to merge 53 commits into from

Conversation

sbromberger
Copy link
Member

This minor change fixes the build errors I reported this morning. Built with gcc 13.2.0 and clang++ 17.0.6.

Test Results
Running tests...                                                                                                             
Test project /home/seth/dev/cpp/ygm/build                                                                                    
      Start  1: SEQ_test_cereal_archive                                                                                      
 1/34 Test  #1: SEQ_test_cereal_archive .............   Passed    0.01 sec                                                   
      Start  2: MPI_test_comm                                                                                                
 2/34 Test  #2: MPI_test_comm .......................   Passed    0.22 sec                                                   
      Start  3: MPI_test_comm_2                                                                                              
 3/34 Test  #3: MPI_test_comm_2 .....................   Passed    0.65 sec                                                   
      Start  4: MPI_test_barrier
 4/34 Test  #4: MPI_test_barrier ....................   Passed    0.17 sec
      Start  5: MPI_test_layout 
 5/34 Test  #5: MPI_test_layout .....................   Passed    0.20 sec
      Start  6: MPI_test_large_messages
 6/34 Test  #6: MPI_test_large_messages .............   Passed    0.27 sec
      Start  7: MPI_test_map
 7/34 Test  #7: MPI_test_map ........................   Passed    0.15 sec
      Start  8: MPI_test_multimap
 8/34 Test  #8: MPI_test_multimap ...................   Passed    0.19 sec
      Start  9: MPI_test_set
 9/34 Test  #9: MPI_test_set ........................   Passed    0.15 sec
      Start 10: MPI_test_bag
10/34 Test #10: MPI_test_bag ........................   Passed    0.19 sec
      Start 11: MPI_test_multiset
11/34 Test #11: MPI_test_multiset ...................   Passed    0.20 sec
      Start 12: MPI_test_array
12/34 Test #12: MPI_test_array ......................   Passed    0.20 sec
      Start 13: MPI_test_disjoint_set
13/34 Test #13: MPI_test_disjoint_set ...............   Passed    0.15 sec
      Start 14: MPI_test_line_parser
14/34 Test #14: MPI_test_line_parser ................   Passed    1.06 sec                                                   
      Start 15: MPI_test_csv_parser                                                                                          
15/34 Test #15: MPI_test_csv_parser .................   Passed    0.10 sec                                                   
      Start 16: MPI_test_csv_headers                                                                                         
16/34 Test #16: MPI_test_csv_headers ................   Passed    0.16 sec
      Start 17: MPI_test_multi_output
17/34 Test #17: MPI_test_multi_output ...............   Passed    0.20 sec
      Start 18: MPI_test_daily_output
18/34 Test #18: MPI_test_daily_output ...............   Passed    0.20 sec
      Start 19: MPI_test_interrupt_mask
19/34 Test #19: MPI_test_interrupt_mask .............   Passed    0.14 sec
      Start 20: MPI_test_random 
20/34 Test #20: MPI_test_random .....................   Passed    0.22 sec
      Start 21: MPI_test_container_traits
21/34 Test #21: MPI_test_container_traits ...........   Passed    0.16 sec
      Start 22: MPI_test_collective
22/34 Test #22: MPI_test_collective .................   Passed    0.18 sec
      Start 23: MPI_test_traits 
23/34 Test #23: MPI_test_traits .....................   Passed    0.19 sec
      Start 24: MPI_test_concepts
24/34 Test #24: MPI_test_concepts ...................   Passed    0.06 sec
      Start 25: MPI_test_recursion_large_messages
25/34 Test #25: MPI_test_recursion_large_messages ...   Passed    0.25 sec
      Start 26: MPI_test_recursion_progress
26/34 Test #26: MPI_test_recursion_progress .........   Passed    0.11 sec
      Start 27: MPI_test_gather_topk
27/34 Test #27: MPI_test_gather_topk ................   Passed    0.28 sec
      Start 28: MPI_test_reduce 
28/34 Test #28: MPI_test_reduce .....................   Passed    0.18 sec
      Start 29: MPI_test_transform
29/34 Test #29: MPI_test_transform ..................   Passed    0.19 sec
      Start 30: SEQ_test_cereal_boost_json
30/34 Test #30: SEQ_test_cereal_boost_json ..........   Passed    0.01 sec
      Start 31: SEQ_test_cereal_boost_container
31/34 Test #31: SEQ_test_cereal_boost_container .....   Passed    0.01 sec
      Start 32: MPI_test_ndjson_parser
32/34 Test #32: MPI_test_ndjson_parser ..............   Passed    0.18 sec
      Start 33: MPI_test_parquet_reader
33/34 Test #33: MPI_test_parquet_reader .............   Passed    0.20 sec
      Start 34: MPI_test_parquet_reader_json
34/34 Test #34: MPI_test_parquet_reader_json ........   Passed    0.22 sec

100% tests passed, 0 tests failed out of 34

Total Test time (real) =   7.08 sec

steiltre and others added 30 commits April 15, 2024 20:01
LLNL#201)

* Updating Github Actions to run on pull requests against our new dev branch names

* Adding quotes around dev branch name
* Updating versions of GCC and Ubuntu in Github Actions

* Updating versions of checkout and cache actions
…splitting and local caches on each process (LLNL#205)

* Rewrites ygm::container::disjoint_set to use union by rank with path-splitting and local caches on each process

* Removing unused code

* Removing unused code

* Clears static structures used in disjoint_set::all_compress()

* Updating disjoint_set cache size

* Updating disjoint_set cache size
…le_next_receive to not require an MPI_Status object (LLNL#206)
Cereal Boost vector

Co-authored-by: Keita Iwabuchi <[email protected]>
* Create cereal_boost_container.hpp

Cereal Boost vector

* Add test for cerealizing boost vector

* Add test_cereal_boost_container in cmake

---------

Co-authored-by: Keita Iwabuchi <[email protected]>
* Add parquet-tools

* Add dump command in parquet-tools

* Enable cmake to find Arrow and Parquet installed by pip

- Add a cmake option `PIP_PYARROW_ROOT` to use Arrow and Parquet installed along with pyarrow by pip.

- Use pip to install Arrow and Parquet in the CI Test.

* Skip testing parquet on ubuntu-20.04.

* User shorter names

---------

Co-authored-by: Keita Iwabuchi <[email protected]>
* Add parquet-tools


---------

Co-authored-by: Keita Iwabuchi <[email protected]>
* Enable Doxygen & RTD

---------

Co-authored-by: Keita Iwabuchi <[email protected]>
Overhaul and standardization of containers using CRTP base classes.
---------

Co-authored-by: Lance Fletcher <[email protected]>
Co-authored-by: Trevor Steil <[email protected]>
* Enable Doxygen & RTD

* Update Doxygen & RTD (merge docs branch)

* Update Doxygen & RTD

* (RTD) Set OS and Python versions

---------

Co-authored-by: Keita Iwabuchi <[email protected]>
* Updated bag, first pass.

* Renamed container traits.   Renamed base_async_insert.

* Added move constructors.

* Renamed old partitioner.

* Wrote the initial boiler plate for set

* Got async_insert for ygm::container::set working.

* Working on map.

* Added move constructor to set class

* Got async_exe_if_contains working

* Changed async_contains interface slightly

* Added base_count class, and added bag::count functionality

* Added base_async_insert_contains class and integrated it into ygm::container::set

* Using tuple concepts.

* Added a few tests to bag

* Split base classes.

* First attempt

* Updating local repo with Roger's changes

* Temporarily commenting out broken tests

* Got multiset converted to CRTP, also added some test cases

* filter, map, flatten

* Updated test_set.cpp

* map, filter, flatten

* base_iteration

* Updates array to use CRTP base classes and adds more tests

* Fixes bug in copy constructor concerning order of initialization of member variables

* Adds ygm::container::array constructors to construct from YGM and STL containers

* adds tests for concepts

* Fixes partitioner initialization in ygm::container::array

---------

Co-authored-by: Roger Pearce <[email protected]>
Co-authored-by: Lance Fletcher <[email protected]>
… a rank that has completed a barrier() and processed on a different rank that has not completed the same barrier() (LLNL#224)
* Adds ability to handle headers in CSV files. Requires allowing ygm::io::line_parser to read the first line of the first file independently and skip over the first line of files in for_all operations.

* Makes ygm::io::detail::csv_line::size() const

* Adds ability to check if ygm::io::csv_parser headers contain a particular label

* Fixes use of ygm::comm::mpi_bcast() in ygm::io::line_parser::read_first()

* Makes skipping first line in line parser controlled by a member variable
* Updates container documentation

* Fixes links in rtd/getting_started page
* Adds batch erase functionality for keys from an STL container

* Adds batch erase keys to map and multimap

* Adds base_batch_erase_key_value

* Adds more batch erase functionality
Added missing cache initialization.
steiltre and others added 23 commits August 3, 2024 14:38
* Fixed reduce() and added test.
* Removes old files.
* renamed transform & added test.
…can create docs (LLNL#250)

* Removing all clever tricks and introducing duplicate code so doxygen can create docs

* Fixing ndjson_parser inheritance from base_iteration_value

* Adds back in missing comm() functions to ygm::io classes

* ygm::container::detail::base_batch_erase_key_value no longer inherits from ygm::container::detail::base_batch_erase_key in order to make inherited member functions to show up in docs properly
* Adds concepts for async_reduce operations

* Fixes reducing_adapter's use of underlying container's partitioner
* Makes lambdas that take user-provided lambdas/functors mutable so captured objects can call non-const functions

* Fixes reduce_by_key lambda
…er() functions to properly use overloaded for_all() operations, such as when calling gather on the output of a filter(). (LLNL#257)
* Adds async_reduce functionality to ygm::container::array

* Removes extra newline
* Makes locations in YGM_CHECK_ASYNC_LAMBDA_COMPLIANCE macro appear as string literals and adds missing check for std::is_standard_layout

* Update base_async_visit.hpp

* Update base_async_visit.hpp

* Update comm.ipp
* Find pyarrow module automatically for Arrow and Parquet

- Find pyarrow module executing python script if A) PIP_PYARROW_ROOT is not set and B) find_package can't find Parquet or Arrow

* Install pyarrow if not found

* Install pyarrow if not found

* Install pyarrow v16.1.* in venv

* Upgrade pip in venv before install pyarrow

* Update FindArrowParquet.cmake

Small typo

---------

Co-authored-by: Keita Iwabuchi <[email protected]>
Co-authored-by: Trevor Steil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants