Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package overhaul #313

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Package overhaul #313

merged 1 commit into from
Nov 2, 2023

Conversation

nabobalis
Copy link
Collaborator

@nabobalis nabobalis commented Nov 1, 2023 •
edited
Loading

Fixes #315

TODO:

  • Changelog for the min python change to 3.9
  • Mention removal of setup and need of modern pip for this to work.
  • Mention the use of * in some functions now
  • Fix CI

@nabobalis nabobalis force-pushed the ci branch 4 times, most recently from 61d071d to 1617056 Compare November 1, 2023 01:14
@nabobalis nabobalis marked this pull request as ready for review November 1, 2023 01:16
wtbarnes
wtbarnes approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for taking this on. Just a few clarification questions.

@wtbarnes
Copy link
Contributor

wtbarnes commented Nov 1, 2023 •
edited
Loading

I noticed that RTD is not reporting its build status back to this PR. Is that just because there hasn't been a push since it was configured for this repo?

@nabobalis nabobalis closed this Nov 1, 2023
@nabobalis nabobalis reopened this Nov 1, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@nabobalis
Copy link
Collaborator Author

I noticed that RTD is not reporting its build status back to this PR. Is that just because there hasn't been a push since it was configured for this repo?

closed and reopened, both it and codecov are now live

@nabobalis nabobalis force-pushed the ci branch 4 times, most recently from 6db1f0e to e34652f Compare November 2, 2023 16:52
@nabobalis
Copy link
Collaborator Author

That RTD build is just spinning: Here is the older one https://aiapy--313.org.readthedocs.build/en/313/ with the same content.

wtbarnes
wtbarnes reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concerned about the additional docs material, specifically naming it a "hands-on guide". The docs may need a refactor, but this should be left to another PR.

@nabobalis nabobalis force-pushed the ci branch 2 times, most recently from 7156624 to 39e449e Compare November 2, 2023 18:25
@nabobalis
Copy link
Collaborator Author

Doc changes removed.

@nabobalis nabobalis merged commit 487a257 into main Nov 2, 2023
@nabobalis nabobalis deleted the ci branch November 2, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtbarnes wtbarnes wtbarnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up CI on GH Actions
2 participants
@nabobalis @wtbarnes