Skip to content

Commit

Permalink
Silently skip variants that currently don't have a supported mapping …
Browse files Browse the repository at this point in the history
…to a transcript.

- If variants partially map outside of a transcript, VV currently does not return a transcript mapping, but also no liftover. As such, we can do nothing.
- See openvar/variantValidator#173.
- Silently skipping these variants for now.
  • Loading branch information
ifokkema committed May 29, 2020
1 parent a2bc76a commit ff31f83
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/scripts/fix_variant_descriptions.php
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,16 @@ function ($sVOT)
&& count($aVV['data']['genomic_mappings']['hg38']) == 1) {
// We have a hg38 DNA column, and this variant has only one hg38 mapping.
$aVV['data']['DNA38_clean'] = substr(strstr($aVV['data']['genomic_mappings']['hg38'][0], ':'), 1);
} elseif (empty($aVV['data']['genomic_mappings']['hg38'])
&& empty($aVV['data']['transcript_mappings'])
&& empty($aUpdate)) {
// Variant has no hg38 mapping, no liftover, and we have nothing to update.
// Probably the mapping isn't supported, because the variant partially lies outside of the transcript.
// On 2020-05-29, that's still a known problem, and probably will be for a while.
// https://github.com/openvar/variantValidator/issues/173
// We've decided, for now, to skip these variants.
$this->nProgressCount ++; // To show progress.
continue; // Then continue to the next variant.
} else {
$this->panic($aVariant, $aVV, 'None or multiple hg38 mappings given for variant.');
}
Expand Down

0 comments on commit ff31f83

Please sign in to comment.