-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add schema validation #40
base: main
Are you sure you want to change the base?
Conversation
LG, overall I prefer this schema over the previous one. Just a few questions:
|
Thanks @rodrigo-ceccato!
Not at all, I am just used to
Yes! I will leave this for last right before we merge.
I was not aware of |
7abf796
to
2637701
Compare
I am fine with pytest, I just thought it was not added to the requirements of the package |
Oh, I didn't understand what you said the first time hehe can I keep pytest then? |
Please do! hehe |
Hey guys, I have an implementation of the schema for the spinner YAML configuration file. To make the implementation simpler, I made some changes to the current schema and I want opinions on this.
applications
. The problem with the current approach is that pydantic doesn't like arbitrary key names in YAML (e.g. the name of the application) mixed with fixed key names (e.g. description, version, runs, ...).Here is an example that is currently accepted by the implementation.
What do you guys think?
TODOs
Non-Trivial Validation
Benchmark parameters must exist in the command templateMisc
Migrate frompytest
tounittest