Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #27

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix typo #27

merged 1 commit into from
Oct 3, 2024

Conversation

AmandaWasserman
Copy link
Collaborator

fixing one silly typo

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Before [fddd309] After [12a5417] Ratio Benchmark (Parameter)
135±1ms 136±1ms 1.01 benchmarks.time_feature_creation
2.64±0.01s 2.64±0.02s 1 benchmarks.time_learn_loop('RandomForest', 'RandomSampling')
2.68±0.01s 2.65±0.02s 0.99 benchmarks.time_learn_loop('RandomForest', 'UncSampling')
170±5ms 166±0.5ms 0.98 benchmarks.time_learn_loop('KNN', 'RandomSampling')
173±3ms 169±2ms 0.98 benchmarks.time_learn_loop('KNN', 'UncSampling')

Click here to view all benchmarks.

drewoldag
drewoldag approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeremykubica jeremykubica merged commit 1bc5acd into main Oct 3, 2024
7 checks passed
@jeremykubica jeremykubica deleted the fix-typo branch October 3, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewoldag drewoldag drewoldag approved these changes

@jeremykubica jeremykubica jeremykubica approved these changes

Assignees

@drewoldag drewoldag

@AmandaWasserman AmandaWasserman

@jeremykubica jeremykubica

@maxwest-uw maxwest-uw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmandaWasserman @drewoldag @jeremykubica @maxwest-uw