Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory benchmarks #38

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add memory benchmarks #38

merged 1 commit into from
Oct 9, 2024

Conversation

jeremykubica
Copy link
Collaborator

Add a pair of memory benchmarks for the learning loop (one using RandomForest and one for KNN)

@jeremykubica jeremykubica requested a review from drewoldag October 9, 2024 18:52
Copy link

github-actions bot commented Oct 9, 2024

Before [06c1a25] After [ca07729] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.peakmem_learn_loop('KNN')
failed failed n/a benchmarks.peakmem_learn_loop('RandomForest')
138±0.6ms 137±2ms 1.00 benchmarks.time_feature_creation
2.66±0.01s 2.67±0.01s 1.00 benchmarks.time_learn_loop('RandomForest', 'RandomSampling')
2.65±0.01s 2.66±0.02s 1.00 benchmarks.time_learn_loop('RandomForest', 'UncSampling')
174±3ms 172±2ms 0.99 benchmarks.time_learn_loop('KNN', 'RandomSampling')
176±0.8ms 173±2ms 0.98 benchmarks.time_learn_loop('KNN', 'UncSampling')

Click here to view all benchmarks.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So quick. Thanks!

@jeremykubica jeremykubica merged commit 051369d into main Oct 9, 2024
7 checks passed
@jeremykubica jeremykubica deleted the fix_benchmarks_push branch October 9, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants