Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken algorithm option #39

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Remove broken algorithm option #39

merged 3 commits into from
Oct 10, 2024

Conversation

jeremykubica
Copy link
Collaborator

The code for gradient_boosted_trees() is commented out with a note "we need to find a non-bugged version of xgboost". This PR removes it as an option so the code doesn't just crash.

Copy link

github-actions bot commented Oct 10, 2024

Before [051369d] After [1985267] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.peakmem_learn_loop('KNN')
failed failed n/a benchmarks.peakmem_learn_loop('RandomForest')
170±2ms 175±4ms 1.03 benchmarks.time_learn_loop('KNN', 'RandomSampling')
174±2ms 179±3ms 1.02 benchmarks.time_learn_loop('KNN', 'UncSampling')
2.67±0.02s 2.68±0s 1.00 benchmarks.time_learn_loop('RandomForest', 'RandomSampling')
139±1ms 136±2ms 0.98 benchmarks.time_feature_creation
2.71±0.02s 2.66±0.01s 0.98 benchmarks.time_learn_loop('RandomForest', 'UncSampling')

Click here to view all benchmarks.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@jeremykubica jeremykubica merged commit 9419bb0 into main Oct 10, 2024
7 checks passed
@jeremykubica jeremykubica deleted the small_cleanups branch October 10, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants