Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmarks.py #40

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Update benchmarks.py #40

merged 1 commit into from
Oct 10, 2024

Conversation

jeremykubica
Copy link
Collaborator

Because of the order of syncs, merges, and PRs, I used the old configuration for the memory benchmark. This updates it to use Max's new configuration object.

Copy link

Before [051369d] After [30478ee] Ratio Benchmark (Parameter)
167±2ms 171±20ms 1.02 benchmarks.time_learn_loop('KNN', 'RandomSampling')
172±2ms 174±2ms 1.01 benchmarks.time_learn_loop('KNN', 'UncSampling')
2.63±0.02s 2.64±0.02s 1.01 benchmarks.time_learn_loop('RandomForest', 'RandomSampling')
173M 173M 1 benchmarks.peakmem_learn_loop('KNN')
168M 168M 1 benchmarks.peakmem_learn_loop('RandomForest')
2.65±0.01s 2.64±0.01s 1 benchmarks.time_learn_loop('RandomForest', 'UncSampling')
138±2ms 136±0.8ms 0.99 benchmarks.time_feature_creation

Click here to view all benchmarks.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good.

@jeremykubica jeremykubica merged commit 83961eb into main Oct 10, 2024
7 checks passed
@jeremykubica jeremykubica deleted the fix_benchmarks branch October 10, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants