Updates to support end-to-end run with laiss-resspect classifier #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click here to view all benchmarks. |
drewoldag
commented
Dec 5, 2024
drewoldag
changed the title
drewoldag
changed the title
… - need to dynamically retrieve the canonical id column name.
…s commit, replacing with dynamic column names.
drewoldag
changed the title
drewoldag
commented
Dec 6, 2024
| @@ -391,6 +391,7 @@ def request_TOM_data(url: str = "https://desc-tom-2.lbl.gov", username: str = No | |||
| dic['mjd_now'] = mjdnow | |||
| if cheat_gentypes is not None: | |||
| dic['cheat_gentypes'] = cheat_gentypes | |||
| dic['include_hostinfo'] = True | |||
There was a problem hiding this comment.
@AmandaWasserman I wanted to check with you to make sure this is ok to keep here. I assume that this will just pull down more data from the TOM and that it wouldn't hurt anything, but if you can confirm that, I would appreciate it.
There was a problem hiding this comment.
I don't think this will affect anything since we go through and pull out the info that we want separately. Will double check this with the smoke test
* Initial commit to implement a "certainty sampler". * Fix spelling error. * Updating comments and logging messages. * Add test for certainty sampling.
…RY` instead of the hardcoded `VALID_STRATEGY` list.
AmandaWasserman
approved these changes
Dec 18, 2024
| @@ -391,6 +391,7 @@ def request_TOM_data(url: str = "https://desc-tom-2.lbl.gov", username: str = No | |||
| dic['mjd_now'] = mjdnow | |||
| if cheat_gentypes is not None: | |||
| dic['cheat_gentypes'] = cheat_gentypes | |||
| dic['include_hostinfo'] = True | |||
There was a problem hiding this comment.
I don't think this will affect anything since we go through and pull out the info that we want separately. Will double check this with the smoke test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively small change, but an important one in order to retrieve data used by the LAISS classifier.
This is a result of the work that @rknop has done, and summarized in this snippet from Slack: "You need to pass the parameter include_hostinfo (set to 1, or, really, something true) to get this additional information."
However, it is also indicative of a broader concern, that each external feature extractor may need to provide a definition of a specific TOM query that is necessary for that specific feature extractor.