Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systematics taustats #324

Merged
merged 14 commits into from
Oct 26, 2023
Merged

Systematics taustats #324

merged 14 commits into from
Oct 26, 2023

Conversation

yomori
Copy link
Contributor

@yomori yomori commented Oct 5, 2023

This PR implements tau stats in psf_diagnostic.py

@yomori
Copy link
Contributor Author

yomori commented Oct 5, 2023

Cross-checked with published DES-Y3 results and get reasonable agreement, but Metacal responses have to applied manually since the Metacal implemented in TXPipe does things differently than how it was actually done in DES-Y3.

txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
@yomori
Copy link
Contributor Author

yomori commented Oct 24, 2023

I remembered that there was an issue with the function load_star_type() so I fixed that as well, which was affecting how the stars were being loaded. I also modified the code such that we only compute for a specific type of star (which now gets specified in the config using star_type = 'PSF-used' or 'PSF-reserved'). The reason for this is because for certain surveys they only provide the catalog for one type of star so it will automatically crash when it tries to compute tau for the other type.

@joezuntz joezuntz merged commit 010ce36 into master Oct 26, 2023
10 checks passed
@joezuntz joezuntz deleted the systematics_taustats branch October 26, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants