Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lf calibration #346

Merged
merged 60 commits into from
May 7, 2024
Merged

Lf calibration #346

merged 60 commits into from
May 7, 2024

Conversation

jmjefferson
Copy link
Collaborator

@jmjefferson jmjefferson commented Apr 12, 2024

KiDS' removes the additive systematic (mean shear), however it should be done separately for North and South fields. In addition, this unifies calibrations for KiDS' and also makes an option to convert psf units from pixels to arcseconds. The metacal calibrations in specifically the psf diagnostics file also had a similar treatment as KiDS which was odd, so that was unified as well.

Copy link
Contributor

@yomori yomori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

various changes

txpipe/calibrate.py Show resolved Hide resolved
txpipe/diagnostics.py Outdated Show resolved Hide resolved
txpipe/diagnostics.py Outdated Show resolved Hide resolved
txpipe/diagnostics.py Outdated Show resolved Hide resolved
txpipe/metadata.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Show resolved Hide resolved
txpipe/test/test_cal_lensfit.py Show resolved Hide resolved
txpipe/utils/calibration_tools.py Show resolved Hide resolved
txpipe/utils/calibration_tools.py Outdated Show resolved Hide resolved
txpipe/utils/calibrators.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@elvinpoole elvinpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. My only comment is we should probably make dec_cut a config option in the source selector stage. just to make it easy for us if we want to switch it off for a given run

@jmjefferson jmjefferson merged commit a849e2d into master May 7, 2024
10 checks passed
@jmjefferson jmjefferson deleted the LFCalibration branch May 7, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants