Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roman_Rubin Updates #242

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Roman_Rubin Updates #242

merged 3 commits into from
Dec 31, 2024

Conversation

evevkovacs
Copy link
Contributor

Here are some minor code updates and some scripts developed jointly with Patricia Larsen for running various DESCQA tests on the roman_rubin catalogs and on skysim5000_v1.1.2.
The modifications include some python updates required for the code to run, some additional plotting options that were convenient for running the tests on the roman_rubin catalogs, and some scripts for running the tests as batch jobs.
Examples of the tests can be seen as follows: dn/dz, dn/dmag delta_sigma, tpcf, ellipticity

@evevkovacs evevkovacs requested a review from yymao December 16, 2024 23:11
@yymao
Copy link
Member

yymao commented Dec 19, 2024

Thanks @evevkovacs.

Would it be better to put the slurm scripts into a directory, say batch_scripts? There are five of those and in the current PR they will all sit in the root directory, which can be confusing?

Otherwise the PR looks good to me.

@evevkovacs
Copy link
Contributor Author

Thanks @yymao. I moved the scripts to batch_scripts. Once you approve, I will merge.

Copy link
Member

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evevkovacs

@evevkovacs evevkovacs merged commit 87bf869 into master Dec 31, 2024
4 checks passed
@evevkovacs evevkovacs deleted the roman_rubin branch December 31, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants