add support for hex and grid layout for DeblendedGalaxy #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test does not pass. But this is the problem of hexalattice. |
|
It is this commit: I report an issue: |
|
Yeah, that's a bug in hexalattice, it shouldn't require that |
|
@esheldon , I think the bug is fixed after the issue in hexalattice is fixed! Could you please review the PR? |
esheldon
requested changes
Jul 26, 2023
|
@esheldon , similar problem in stack, I think the problem comes with |
esheldon
requested changes
Dec 1, 2023
esheldon
requested changes
Dec 1, 2023
descwl_shear_sims/sim.py
Outdated
| @@ -29,9 +29,9 @@ | |||
| # randomize the psf fwhm and shape for each trial. PSF is still same | |||
| # for all epochs/bands | |||
| "randomize_psf": False, | |||
| "coadd_dim": 250, | |||
| "coadd_dim": 300, | |||
There was a problem hiding this comment.
this breaks backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #152
The galaxy number density is determined by the layout for these two cases.