Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set a fixed dithering amount #220

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

zhouconghao
Copy link
Member

This enables testing the pixel interpolation effect with a fixed offset between the SE WCS and coadd WCS. Let me know if I should come up with a test or change anything. Thanks!

@zhouconghao
Copy link
Member Author

Somehow the test got an error in conda install. Pasted here

Preparing transaction: ...working... done
Verifying transaction: ...working... done
Executing transaction: ...working... done
warning  libmamba Could not parse mod/etag header
warning  libmamba Could not parse mod/etag header
warning  libmamba Could not parse mod/etag header
warning  libmamba Could not parse mod/etag header
warning  libmamba Could not parse mod/etag header
warning  libmamba Could not parse mod/etag header
Download error (28) Timeout was reached [https://conda.anaconda.org/conda-forge/linux-64/htcondor-utils-23.0.3-h841b71b_0.conda]
Operation timed out after 9053 milliseconds with 0 bytes received
error    libmamba Error when extracting package: std::bad_alloc
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
/home/runner/work/_temp/677bb002-520b-44d9-8240-544f958b1106.sh: line 9:  1999 Aborted                 (core dumped) mamba install -q --file requirements.txt
Error: Process completed with exit code 134.

will try later.

Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments below, I think we should change the keyword argument to dither_size.

descwl_shear_sims/sim.py Show resolved Hide resolved
descwl_shear_sims/wcs/sewcs.py Outdated Show resolved Hide resolved
@beckermr beckermr requested a review from esheldon December 18, 2024 17:15
descwl_shear_sims/sim.py Outdated Show resolved Hide resolved
descwl_shear_sims/wcs/sewcs.py Outdated Show resolved Hide resolved
@esheldon esheldon merged commit 106a5a7 into LSSTDESC:master Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants