-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new notebook for quality control #168
base: main
Are you sure you want to change the base?
add a new notebook for quality control #168
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1 ☔ View full report in Codecov by Sentry. |
The smoke test is passed, so that's good. One question: is it your intention to change the BPZ notebook? I see that the run number is changed. If not, can you roll back? |
…otebook-for-quality-control
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I noticed a few things which you might want to change:
- The output for
somocluSOM_demo.ipynb
is not cleared - In
somocluSOM_cluster_qc_demo.ipynb
, under SectionNow let's do the quality control.
below the cell[29]
there is a markdown cell which I think should have been code? - The three notebooks seems to overlap a lot in content. Are they intended to be like this? (Not asking you to remake / change things, just pointing this out in case you meant to remove some repeated content. If not that's totally fine!)
Problem & Solution Description (including issue #)
Code Quality
#pragma: no cover
; in the case of a bugfix, a new test that breaks as a result of the bug has been added