Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix variance/sigma bug #22

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix variance/sigma bug #22

merged 1 commit into from
Aug 29, 2024

Conversation

ztq1996
Copy link
Contributor

@ztq1996 ztq1996 commented Aug 29, 2024

qp norm takes sigma, not variance

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.39%. Comparing base (5860497) to head (743abaa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   64.39%   64.39%           
=======================================
  Files           2        2           
  Lines         514      514           
=======================================
  Hits          331      331           
  Misses        183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ztq1996 ztq1996 requested a review from sschmidt23 August 29, 2024 17:20
Copy link
Collaborator

@sschmidt23 sschmidt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, looks good.

@sschmidt23 sschmidt23 merged commit 0b62771 into main Aug 29, 2024
7 checks passed
@ztq1996 ztq1996 deleted the tqz/debug_variance branch August 29, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants