Cipher #30
Open
Cipher #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianaHY
reviewed
Feb 13, 2020
src/cipher.js
Outdated
| @@ -1,9 +1,19 @@ | |||
| window.cipher.encode(offset, string) => | |||
| window.cipher = { //window valor global, cipher es el objeto | |||
| encode(string, offset) => { //Codificar, cadena de texto, numero de desplazamiento | |||
There was a problem hiding this comment.
window porque es una forma global de manejar los eventos y propiedades del dom y cipher solo es el objeto con el que se esta trabajando
AdrianaHY
reviewed
Feb 13, 2020
src/cipher.js
Outdated
| let wordCipher = ""; //variable para que introduzcan la palabra a descifrar | ||
| for ( i = 0; i < string.lenght; i++ ){ //mi ciclo "for" se va a estar ejecutando cada que el usuario introduzca una cadena de texto e ira incrementando | ||
| let word = string[i]; //variable que declara que word es igual a una cadena de texto[incrementar] | ||
| if (word.match(/[a-z]/i)){//mi variable word solo se va a ejecutar siempre y cuando sea equivalente a solo letras |
There was a problem hiding this comment.
gracias, así "desmenuzandolo" es una manera mas fácil de comprender un poco porque lleva cada cosa
AdrianaHY
reviewed
Feb 13, 2020
| } | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
En general todo muy bien, cuida tu indentación!
AdrianaHY
reviewed
Feb 13, 2020
src/index.html
Outdated
| <div class="contenedor"> | ||
| <div class= "elemento elemento0"><h1>¡Advertencia!</h1><br></div> | ||
|
|
||
| <div class= "elemento elemento1">Solo se pueden utilizar Mayúsculas</div> | ||
| <div class= "elemento elemento2">No admite letra "Ñ"</div> | ||
| <div class= "elemento elemento3">No admite caracteres ni numeros</div> | ||
|
|
||
|
|
||
| <br> | ||
| <form method="post" action="index2.html"> |
There was a problem hiding this comment.
Trata de encontrar una forma de no utilizar
, se puede arreglar con CSS.
There was a problem hiding this comment.
si claro en un momento lo arreglo
|
Muchas gracias es un pequeño avance pero significativo para mí 🖤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buenos días, aquí esta mi proyecto "Cipher", tuve muchos inconvenientes con CSS pero después de ver lo de flexbox me quedo un poco mas claro pero no pude solucionar poner mi background completo y la "caja" de la pagina principal se centre verticalmente y tuve que solucionar metiendo saltos de linea, pero la gran duda que tengo es la siguiente, gracias al feedback de Bliss decidí meterle un botón"switch" a base de un checkbox mi pregunta es ¿Se puede meter dos variables en un mismo botón al hacer clic?