Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added swhub #1447

Closed
wants to merge 2 commits into from
Closed

Added swhub #1447

wants to merge 2 commits into from

Conversation

MatthiasLettner
Copy link
Contributor

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

github-actions[bot]
github-actions bot requested changes Nov 13, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@MatthiasLettner
Copy link
Contributor Author

my servername is the directory name

maaaathis
maaaathis suggested changes Nov 13, 2024
View reviewed changes
minecraft_servers/swhub/manifest.json Outdated
@@ -0,0 +1,25 @@
{
"server_name": "SWHub",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server_name must be lowercase

minecraft_servers/swhub/manifest.json Outdated
],
"social": {
"web": "https://swhub.net",
"web_shop": "https://lodianet.tebex.io",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns error 404

DoJapHD
DoJapHD requested changes Nov 13, 2024
View reviewed changes
minecraft_servers/swhub/manifest.json Outdated
@@ -0,0 +1,25 @@
{
"server_name": "SWHub",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to all lowercase

minecraft_servers/swhub/manifest.json Outdated
],
"social": {
"web": "https://swhub.net",
"web_shop": "https://lodianet.tebex.io",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404

@DoJapHD
Copy link
Collaborator

DoJapHD commented Nov 13, 2024

Oh well, you already did that matthis xd

@maaaathis
Copy link
Contributor

maaaathis commented Nov 13, 2024 •
edited
Loading

Oh well, you already did that matthis xd

sry haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoJapHD DoJapHD DoJapHD requested changes

@github-actions github-actions[bot] github-actions[bot] requested changes

@maaaathis maaaathis maaaathis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthiasLettner @DoJapHD @maaaathis