Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add KansyFamily.net #1453

Merged
merged 11 commits into from
Nov 17, 2024
Merged

add KansyFamily.net #1453

merged 11 commits into from
Nov 17, 2024

Conversation

KansyYT
Copy link
Contributor

@KansyYT KansyYT commented Nov 17, 2024

Laby.net server liste alles geaddet

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Laby.net server liste alles geaddet
@KansyYT KansyYT changed the title laby.net Server ansicht KansyFamily.net Nov 17, 2024
@KansyYT KansyYT changed the title KansyFamily.net add KansyFamily.net Nov 17, 2024
Copy link
Contributor

@maaaathis maaaathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory name needs to be lowercase

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress this file.

@@ -0,0 +1,54 @@
{
"server_name": "KansyFamily",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server_name needs to be lowercased

"nice_name": "KansyFamily",
"direct_ip": "KansyFamily.net",
"server_wildcards": [
"%.KansyFamily.net"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like a real wildcard:
image

],
"social": {
"web": "https://KansyFamily.net",
"web_shop": "https://shop.KansyFamily.net",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not reachable

"tiktok": "kansyfamily"
},
"gamemodes": {
"KansyAttack": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key must be lowercase

"name": "1vs1",
"color": "#fcd8d8"
},
"Flags": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key must be lowercase

},
"discord": {
"server_id": 1101535267355103353,
"rename_to_minecraft_name": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true is reserverd for partners only; change to false if ur not a LabyMod partner

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Update all
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@KansyYT
Copy link
Contributor Author

KansyYT commented Nov 17, 2024

All update

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

},

"gamemodes": {
"kansyAttack": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All lowerkey

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all empty lines

@KansyYT
Copy link
Contributor Author

KansyYT commented Nov 17, 2024

Update the image and Remove all empty

@DoJapHD DoJapHD merged commit 57b6d45 into LabyMod:master Nov 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants