Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest.json Erstellt #1468

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

manifest.json Erstellt #1468

wants to merge 15 commits into from

Conversation

NextPlatziReal
Copy link

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

github-actions[bot]
github-actions bot requested changes Nov 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please use your own page, not LABY.net (user_stats)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

maaaathis
maaaathis suggested changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@maaaathis maaaathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • directory name has to be lowercase

  • icon.png is not given, but it is required.

  • [email protected] is not given, but it is required.

DoJapHD
DoJapHD reviewed Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@DoJapHD DoJapHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change folder name to lowercase

minecraft_servers/PlatziLegends/background.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

minecraft_servers/PlatziLegends/[email protected] Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

minecraft_servers/PlatziLegends/manifest.json
@@ -0,0 +1,26 @@
{
"server_name": "PlatziLegends",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to lowercase

github-actions[bot]
github-actions bot requested changes Nov 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!
Custom Discord invites are reserved for LabyMod Partners.
If you are a partner, please ignore this message.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Nov 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!
Custom Discord invites are reserved for LabyMod Partners.
If you are a partner, please ignore this message.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Nov 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!
Custom Discord invites are reserved for LabyMod Partners.
If you are a partner, please ignore this message.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Nov 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!
Custom Discord invites are reserved for LabyMod Partners.
If you are a partner, please ignore this message.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Nov 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom Discord invites are reserved for LabyMod Partners.
If you are a partner, please ignore this message.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@DoJapHD
Copy link
Collaborator

DoJapHD commented Nov 23, 2024

Our check is faulty, ignore the error

github-actions[bot]
github-actions bot requested changes Nov 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom Discord invites are reserved for LabyMod Partners.
If you are a partner, please ignore this message.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@DoJapHD
Copy link
Collaborator

DoJapHD commented Nov 23, 2024

Again, our script is broken right now.
Please wait.

github-actions[bot]
github-actions bot requested changes Nov 23, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom Discord invites are reserved for LabyMod Partners.
If you are a partner, please ignore this message.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoJapHD DoJapHD DoJapHD left review comments

@github-actions github-actions[bot] github-actions[bot] requested changes

@maaaathis maaaathis maaaathis requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NextPlatziReal @DoJapHD @maaaathis