Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consuming new certificate API #6

Merged
merged 12 commits into from
Nov 7, 2023
Merged

Conversation

rufiss
Copy link
Contributor

@rufiss rufiss commented Nov 3, 2023

No description provided.

@rufiss rufiss requested a review from medisco November 3, 2023 18:00
Copy link
Contributor

@medisco medisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments

lib/amplia-client.js Outdated Show resolved Hide resolved
lib/amplia-client.js Outdated Show resolved Hide resolved
lib/issue-software-certificate-response.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@medisco
Copy link
Contributor

medisco commented Nov 6, 2023

You should make some integration tests for this new feature. Please look at the branch https://github.com/LacunaSoftware/AmpliaNodeClient/tree/tests/confluence-test-cases, some of the tests we are making in this library.

Copy link
Contributor

@medisco medisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rufiss rufiss merged commit c761c28 into develop Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants